Skip to content

sync RPM spec w/ upstream #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

rcsanchez97
Copy link
Contributor

note: back out gcc-15 patch, since it wouldn't apply in any event
Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A passing question, but otherwise, LGTM.

@@ -259,6 +263,10 @@ exit $ret


%changelog
* Tue Feb 18 2025 Remi Collet <[email protected]> - 1.30.0-2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming, do we want to also exclude this changelog entry since it doesn't apply? Or do we only need to apply the minimal changes necessary for CI purposes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we want to leave it in. If we needed to remove it, that would be done via spec.patch. The Evergreen task will download the mongo-c-driver.spec file from downstream and diff it with the one we have vendored. If there is any diff, the task fails (to alert us to the need to sync it). So, we need to have the same (bit-for-bit identical) spec file, and the changes made by spec.patch only need to be functional. The changelog entries mostly don't matter since our snapshot script creates a new changelog entry as part of the task anyways.

@rcsanchez97 rcsanchez97 merged commit 9049872 into mongodb:master Feb 20, 2025
40 of 43 checks passed
@rcsanchez97 rcsanchez97 deleted the sync_rpm_spec branch February 20, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants