CDRIVER-5880: Remove workaround for DRIVERS-3095, defer other test improvements #1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
DRIVERS-3095: Use extjson Infinity representation in float32 vector test
mongodb/specifications#1767
Merged
3 tasks
ghost
requested a review
from 
eramongodb
approved these changes
Mar 7, 2025
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the proposed spec change for DRIVERS-3095, and it removes the workarounds which are no longer needed due to the change. (Extended JSON infinities now pass through without special treatment.)
Spec PR:
mongodb/specifications#1767
The C driver test code had noted several other opportunities to improve spec tests. These are no longer associated with any tickets, so I've updated the comments to be generic TODOs rather than referencing closed tickets.