Skip to content

CDRIVER-5924 test on Graviton #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

CDRIVER-5924 test on Graviton #1905

merged 2 commits into from
Mar 12, 2025

Conversation

kevinAlbs
Copy link
Collaborator

Summary

Test on Graviton with latest server

Background & Motivation

Testing Graviton is requested in DRIVERS-2436. MongoDB servers on Graviton is expected to be more common. Additional testing appears motivated by server issues encountered on Graviton. HELP-37322 references two behavior differences:

  1. SERVER-69612: char is unsigned on ARM.
  2. SERVER-69611: gcc may enable a default for -ffp-contract (which differs from clang).

Neither appear specific to Graviton. (1) applies to other ARM CPUs. The C driver already tests on arm (via ubuntu2004-arm64). (2) appears non-applicable to the C driver. Quoting https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html:

The default is -ffp-contract=off for C in a standards compliant mode

The C driver specifies C99 by default. So I expect the default C build agrees with clang. Regardless, I expect there are few floating point algorithms in the driver that would be affected.

Though the server supports arm on 4.2-latest, this PR proposes only testing the latest server. The C driver already tests on ARM (via ubuntu2004-arm64). And a patch build testing 4.2-latest servers showed no issues.

Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinAlbs kevinAlbs merged commit 0dfdb56 into mongodb:master Mar 12, 2025
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants