CDRIVER-5743 Followup fix for signedness warning #1907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
kevinAlbs
approved these changes
Mar 11, 2025
kevinAlbs
pushed a commit
to kevinAlbs/mongo-c-driver
that referenced
this pull request
May 16, 2025
kevinAlbs
added a commit
that referenced
this pull request
May 19, 2025
#2015) * CDRIVER-5743: NUL terminate string, handle more error cases (#1903) * NUL termination and error handling fixes for mongoc_secure_channel_setup_ca * CDRIVER-5743 Followup fix for signedness warning (#1907) * CDRIVER-3228 fix memory leaks in SChannel cert loading (#2009) * Store and free client cert context * Free on successful load of client cert ** Do not return before `fail` label. * Free `hKey` * Free pem file and cert when loading CA file * Release provider context on error * NUL terminate pem file contents ** To ensure `strstr` does not read past memory on failure to find. * Remove unused printf * Add `read_file_and_null_terminate` helper * Rename `encrypted_*` to `encoded_*` ** Encrypted keys are not supported with SChannel. ** "encoded" is consistent with naming in WinCrypt API. * check if `pem_public` is NULL ** Avoids NULL deref if PEM file does not have public cert * Remove call to `CryptQueryObject` for public cert ** The flag `CERT_QUERY_CONTENT_FLAG_ALL` is likely incorrect (only certificate is expected) * Remove call to `CryptQueryObject` for CRL ** Return was wrongly stored in a `CERT_CONTEXT` (needed `CRL_CONTEXT`). ** Use `CertCreateCRLContext` for consistency with other PEM-reading functions. * Remove unused params --------- Co-authored-by: mdbmes <[email protected]> Co-authored-by: Ezra Chung <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a signed comparison added in #1903. (winssl only)