CDRIVER-4489 promote empty username to client error #1939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Mar 20, 2025
| BSON_ASSERT_PARAM (mechanism); | ||
| BSON_ASSERT_PARAM (user_prefix); | ||
|
|
||
| bson_error_t error; |
There was a problem hiding this comment.
Move declaration inside scope block to fix warnings on Evergreen tasks:
../../../src/libmongoc/tests/test-mongoc-uri.c: In function '_auth_mechanism_password_prohibited':
../../../src/libmongoc/tests/test-mongoc-uri.c:339:20: error: declaration of 'error' shadows a previous local [-Werror=shadow]
339 | bson_error_t error;
| ^~~~~
Comment on lines
326
to
327
| mongoc_uri_t *const uri = mongoc_uri_new_with_error ( | ||
| tmp_str ("mongodb://localhost/?" MONGOC_URI_AUTHMECHANISM "=%s%s", mechanism, uri_suffix), &error); |
There was a problem hiding this comment.
Suggested change
| mongoc_uri_t *const uri = mongoc_uri_new_with_error ( | |
| tmp_str ("mongodb://localhost/?" MONGOC_URI_AUTHMECHANISM "=%s%s", mechanism, uri_suffix), &error); | |
| mongoc_uri_t *const uri = mongoc_uri_new_with_error ( | |
| tmp_str ("mongodb://%s@localhost/?" MONGOC_URI_AUTHMECHANISM "=%s%s", user_prefix, mechanism, uri_suffix), | |
| &error); |
Suggest including user_prefix. IIUC this helper only intends to test changes in the password and keep the rest of the URI fixed.
If accepted, also update or remove the ASSERT_CMPSTR (mongoc_uri_get_username (uri), NULL); below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1896. Enforces that even optional usernames are non-empty when specified (there are no cases where an empty username is desirable).