Skip to content

CDRIVER-4489 update URI documentation for authMechanismProperties #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 20, 2025

Conversation

eramongodb
Copy link
Contributor

@eramongodb eramongodb commented Mar 19, 2025

Followup to #1896 which updates API documentation for relevant URI options (CDRIVER-4489). Additionally deprecates old GSSAPI URI options in favor of using authMechanismProperties instead (CDRIVER-5933).

This PR also preemptively adds the warning required by the Authentication spec:

Note: because the TOKEN_RESOURCE is often itself a URL, drivers MUST document that a TOKEN_RESOURCE with a comma , must be given as a MongoClient configuration and not as part of the connection string, and that the TOKEN_RESOURCE value can contain a colon : character.

The wording is adjusted to indicate that mongoc will interpret the presence of a comma as a key-value pair delimiter. More importantly, in contrast to the spec and associated spec tests, percent-encoded commas will be permitted as an extension to improve user experience, as they do not interfere with the parsing of authMechanismProperties or the connection string as implied by the spec. This requires upcoming changes which are separate from this PR.

Aside: ReStructuredText is painpainpain. 🫠

@eramongodb eramongodb requested a review from kevinAlbs March 19, 2025 20:45
@eramongodb eramongodb self-assigned this Mar 19, 2025
@eramongodb eramongodb requested a review from kevinAlbs March 20, 2025 14:53
@eramongodb eramongodb merged commit ec1dac5 into mongodb:master Mar 20, 2025
40 of 42 checks passed
@eramongodb eramongodb deleted the cdriver-docs branch March 20, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants