Use majority write concern and remove assert in change stream tests #1980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eramongodb
approved these changes
Apr 3, 2025
|
Once merged, please cherry-pick onto the |
kevinAlbs
added a commit
that referenced
this pull request
Apr 3, 2025
…1980) * use majority write concern in change stream test * do not assert that resume token changed after receiving no documents
kevinAlbs
added a commit
that referenced
this pull request
Apr 3, 2025
…1980) * use majority write concern in change stream test * do not assert that resume token changed after receiving no documents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/change_stream/batchSize0./change_stream/live/track_resume_token.Background & Motivation
Using majority write concern is intended to address this observed test failure, which receives only one of two expected events.
The faulty assert removal follows mongodb/mongo-cxx-driver#1367, which made a similar change in the C++ driver test runner. I suspect the C++ tests were based off of the C driver tests.