Skip to content

Allow libbson and libmongoc library names to be changed externally #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2019

Conversation

eldruin
Copy link
Contributor

@eldruin eldruin commented Nov 8, 2019

Internally we rename the libraries we integrate as to avoid interference with the library versions already available on the target systems by giving them a prefix.
This PR allows users to specify, for example:

-DBSON_OUTPUT_BASENAME:STRING=MYORG_bson
-DMONGOC_OUTPUT_BASENAME:STRING=MYORG_mongoc

I used BASENAME as the flavor and/or version are appended later.

Alternatively, it would be also fine for us to add a prefix variable like OUTPUT_NAME_PREFIX or so but I was unable to find a good name that cannot be confused the target PREFIX property (e.g. lib)

Copy link
Contributor

@rcsanchez97 rcsanchez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look right to me, except for two very minor style issues. I've started the Evergreen patch build, so once the Travis and Evergreen builds complete, assuming no issues, I'll follow-up again with an approval.

@rcsanchez97
Copy link
Contributor

@kevinAlbs Do these options to you like they should be documented in installing.rst? We don't document every build option it seems and there isn't a place where these naturally fall in that document, so it would need a new section. Also, do you have any reservations regarding this change?

@rcsanchez97
Copy link
Contributor

Some build tasks are failing in Evergreen. A few I immediately recognize as known issues that are definitely not related to this change. I will need to confirm the others, but I honestly do not expect that any of the failures will be attributable to this change.

@kevinAlbs
Copy link
Collaborator

Thanks for the contribution @eldruin!

@kevinAlbs kevinAlbs self-requested a review November 8, 2019 17:52
@rcsanchez97 rcsanchez97 merged commit 2a57077 into mongodb:master Nov 8, 2019
@eldruin eldruin deleted the external-library-rename branch November 8, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants