CDRIVER-3422 add unified test setup/teardown #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
changed the title
kevinAlbs
changed the title
kevinAlbs
changed the title
kevinAlbs
commented
Nov 30, 2020
| test_runner_t *test_runner; | ||
| test_file_t *test_file; | ||
| test_t *test; | ||
| } test_diagnostics; |
There was a problem hiding this comment.
It's not yet clear to me whether this is useful. The spec recommends not aborting while a test is running so server state can be cleaned up:
If at any point while executing this test an unexpected error is encountered or an assertion fails, the test runner MUST consider this test to have failed and SHOULD continue with the instructions in this section to ensure that the test environment is cleaned up (e.g. disable fail points, kill sessions) while also forgoing any additional assertions.
I plan to havetest_run return an error instead of aborting when something within the test fails. So, if that means the signal handler diagnostics is not useful, I may remove it later.
bazile-clyde
reviewed
Dec 3, 2020
kevinAlbs
commented
Dec 3, 2020
chardan
pushed a commit
to chardan/mongo-c-driver
that referenced
this pull request
Aug 26, 2021
Tweak make_release.py - add requirements.txt for dependencies - add --skip-distcheck option - fail if running on Python 2 - fix some pylint errors - refactor running shell script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of unified test runner:
Next up: creating and tearing down the entity map for each test.