Don't inspect error messages for "not master" or "node is recovering" #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
commented
Mar 9, 2021
There was a problem hiding this comment.
@bazile-clyde @samantharitter: The changes are complete, but I'm not sure about two things that I've highlighted below. I'd appreciate your opinion on how to best proceed.
alcaeus
force-pushed
the
cdriver-3885
branch
3 times, most recently
from
1df16ab to
caf940c
Compare
bazile-clyde
suggested changes
Mar 11, 2021
| @@ -182,7 +184,8 @@ test_state_change_helper (uint32_t domain, bool expect_error) | |||
| BSON_ASSERT (expect_error == _mongoc_error_is_state_change (&error)); | |||
| } | |||
|
|
|||
| error.code = 123; | |||
| /* Fallback code that's used when no code was returned */ | |||
| error.code = 17; | |||
There was a problem hiding this comment.
Could we make this MONGOC_ERROR_QUERY_FAILURE? That way it's easier to see where it came from. It'll also be easier to grep for later.
| @@ -2055,8 +2055,8 @@ test_request_scan_on_error () | |||
| NULL /* server_err */); | |||
| /* for an unknown code, the message should still be checked. */ | |||
There was a problem hiding this comment.
This comment is stale right? Previously, we would check the error message in the default case. Now we do not and return false. If so, we can remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers CDRIVER-3885 and CDRIVER-3884.