Skip to content

set distinct.query as document #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Conversation

bazile-clyde
Copy link
Contributor

@bazile-clyde bazile-clyde commented Mar 9, 2021

This commit fixes the issue from the task test-latest-server-auth-sasl-openssl-cse on GCC 8.3 here. Unfortunately, that task now has another unrelated error.

Here's a patch showing the previously failing tasks succeeding (link). I also verified this locally.

@@ -760,7 +760,9 @@ operation_distinct (test_t *test,
"key",
BCON_UTF8 (field_name),
"query",
&filter);
"{",
&filter,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From MongoDB's docs here, the query field of a distinct command should be a document. Previously, we were setting it as a string.

See the docs for BCON_NEW for an example of how to use this function.

@bazile-clyde bazile-clyde requested a review from alcaeus March 9, 2021 17:48
@codecov-io
Copy link

codecov-io commented Mar 9, 2021

Codecov Report

Merging #748 (354abff) into master (4184f37) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   60.91%   60.80%   -0.11%     
==========================================
  Files         278      278              
  Lines       73398    73398              
==========================================
- Hits        44709    44630      -79     
- Misses      28689    28768      +79     
Impacted Files Coverage Δ
src/libmongoc/tests/unified/operation.c 23.51% <ø> (ø)
src/libmongoc/tests/test-mongoc-async.c 3.81% <0.00%> (-25.20%) ⬇️
src/libmongoc/tests/test-mongoc-primary-stepdown.c 3.04% <0.00%> (-9.14%) ⬇️
src/libmongoc/tests/test-mongoc-counters.c 66.56% <0.00%> (-6.39%) ⬇️
src/libmongoc/src/mongoc/mongoc-read-prefs.c 85.61% <0.00%> (-0.72%) ⬇️
src/libmongoc/tests/test-mongoc-stream-tls-error.c 96.95% <0.00%> (-0.61%) ⬇️
src/libbson/src/bson/bson-iter.c 89.71% <0.00%> (-0.54%) ⬇️
src/libmongoc/tests/test-mongoc-socket.c 98.28% <0.00%> (-0.43%) ⬇️
src/libmongoc/tests/unified/runner.c 66.33% <0.00%> (-0.15%) ⬇️
src/libmongoc/src/mongoc/mongoc-server-monitor.c 62.04% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4184f37...354abff. Read the comment docs.

@bazile-clyde bazile-clyde merged commit 26898e5 into mongodb:master Mar 9, 2021
chardan pushed a commit to chardan/mongo-c-driver that referenced this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants