Skip to content

Update versioned API getters #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 25, 2021
Merged

Update versioned API getters #765

merged 7 commits into from
Mar 25, 2021

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Mar 24, 2021

This PR collects a few fixes that were necessary to get the PHP changes running after the introduction of mongoc_optional_t:

  • Arguments for mongoc_optional_t getters were not marked as const
  • Arguments for mongoc_server_api_t getters were not marked as const
  • mongoc_server_api_get_strict had a wrong name
  • Added mongoc_server_api_get_version to retrieve the mongoc_server_api_version_t
  • Added documentation for mongoc_server_api_get_*
  • Added documentation for mongoc_optional_t.

@alcaeus alcaeus self-assigned this Mar 24, 2021
@alcaeus alcaeus mentioned this pull request Mar 24, 2021
Merged
bazile-clyde
bazile-clyde suggested changes Mar 24, 2021
View reviewed changes
@alcaeus alcaeus force-pushed the versioned-api-getters branch from 1cd6d0a to 593c33e Compare March 25, 2021 07:38
@alcaeus alcaeus requested a review from bazile-clyde March 25, 2021 07:39
bazile-clyde
bazile-clyde approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@bazile-clyde bazile-clyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alcaeus alcaeus merged commit 56ebd0f into mongodb:master Mar 25, 2021
@alcaeus alcaeus deleted the versioned-api-getters branch March 25, 2021 14:59
chardan pushed a commit to chardan/mongo-c-driver that referenced this pull request Aug 26, 2021
@kevinAlbs
CXX-2171 use wc/rc majority in CSFLE prose tests (mongodb#765)
3c7609f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazile-clyde bazile-clyde bazile-clyde approved these changes

@samantharitter samantharitter Awaiting requested review from samantharitter

Assignees

@alcaeus alcaeus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alcaeus @bazile-clyde