-
Notifications
You must be signed in to change notification settings - Fork 455
CDRIVER-3909 topology description copy/destroy methods #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with suggestions applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@tanlisu: This was just rebased on master. That should help when updating the submodule in mongodb/mongo-php-driver#1244. |
mongodb/mongo-php-driver#1244 demonstrated this this API works, so I'll merge once CI is green. |
2da0543
to
8ce9c63
Compare
update _mongoc_topology_description_monitor_opening to use mongoc_topology_description_cleanup instead of mongoc_topology_description_destroy
https://jira.mongodb.org/browse/CDRIVER-3909