Skip to content

CDRIVER-3909 topology description copy/destroy methods #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 16, 2021

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Apr 23, 2021

@jmikola jmikola requested review from alcaeus and kevinAlbs April 23, 2021 16:02
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions applied.

Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmikola
Copy link
Member Author

jmikola commented Aug 4, 2021

@tanlisu: This was just rebased on master. That should help when updating the submodule in mongodb/mongo-php-driver#1244.

@jmikola jmikola changed the title CDRIVER-3909 topology description copy/destroy methods [WAIT] CDRIVER-3909 topology description copy/destroy methods Aug 4, 2021
@jmikola jmikola changed the title [WAIT] CDRIVER-3909 topology description copy/destroy methods CDRIVER-3909 topology description copy/destroy methods Aug 11, 2021
@jmikola
Copy link
Member Author

jmikola commented Aug 11, 2021

mongodb/mongo-php-driver#1244 demonstrated this this API works, so I'll merge once CI is green.

@jmikola
Copy link
Member Author

jmikola commented Aug 11, 2021

Note: the ASAN failures here appear to be legitimate issues so I'm going to spend some more time on investigating and fixing this. For the time being I'm going to rebase on an earlier libmongoc commit before fdc2de4 to unblock @tanlisu in #785.

@jmikola jmikola merged commit d283803 into mongodb:master Aug 16, 2021
@jmikola jmikola deleted the cdriver-3909 branch August 16, 2021 19:28
chardan pushed a commit to chardan/mongo-c-driver that referenced this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants