CDRIVER-3974 Append Versioned API options to all commands #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran a build with a temporary patch for the cursor/getMore issue: https://spruce.mongodb.com/version/60a3b3f80305b944948f6b9b/tasks. No idea why debug-compile-sspi-winssl failed, but the rest of the tests is stable. |
This was referenced May 19, 2021
kevinAlbs
approved these changes
May 21, 2021
There was a problem hiding this comment.
LGTM!
No idea why debug-compile-sspi-winssl failed, but the rest of the tests is stable.
Unfortunately, this is a known flaky test failure, tracked in: CDRIVER-3760. I think it is unrelated to these changes.
| if (parts->client->api) { | ||
| if (!is_get_more && !_txn_in_progress (parts)) { |
There was a problem hiding this comment.
Nice! Always appending a versioned API does help simplify this logic.
kevinAlbs
pushed a commit
that referenced
this pull request
Jun 3, 2021
chardan
pushed a commit
to chardan/mongo-c-driver
that referenced
this pull request
Aug 26, 2021
* Allow configuration of server API on a Client * Add versioned API spec tests * Use server_description_hello_response instead of legacy command * Add batchSize workaround for getMore in CM spec tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDRIVER-3974
This fixes test failures in the versioned_api builds. Other builds against latest will continue to fail due
batchSizecalculation forgetMoreresulting in additionalgetMorecalls.