-
Notifications
You must be signed in to change notification settings - Fork 455
Fix: CDRIVER-4050: Set the correct uploadDate on GridFS files #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a3a86b7
to
1c3468e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have a question about the new API.
|
Previously used the time from bson_get_monotonic_time(), which is incorrect on most systems, as it is usually realtive to the system uptime and is stored as microseconds, whereas uploadDate should be stored as number of milliseconds since the Unix Epoch.
c4959f0
to
665668c
Compare
Rebased onto the recent master branch has test results in-sync with that branch. Should be ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Feel free to merge.
Previously used the time from bson_get_monotonic_time(), which is
incorrect on most systems, as it is usually realtive to the system
uptime and is stored as microseconds, whereas uploadDate should be
stored as number of milliseconds since the Unix Epoch.