Skip to content

Fix: CDRIVER-4050: Set the correct uploadDate on GridFS files #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 4, 2021

Conversation

vector-of-bool
Copy link
Contributor

Previously used the time from bson_get_monotonic_time(), which is
incorrect on most systems, as it is usually realtive to the system
uptime and is stored as microseconds, whereas uploadDate should be
stored as number of milliseconds since the Unix Epoch.

Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a question about the new API.

@kevinAlbs
Copy link
Collaborator

/gridfs_old/create_from_stream appears to be failing on the attached Evergreen patch build.

@vector-of-bool vector-of-bool requested a review from kevinAlbs July 12, 2021 16:08
Previously used the time from bson_get_monotonic_time(), which is
incorrect on most systems, as it is usually realtive to the system
uptime and is stored as microseconds, whereas uploadDate should be
stored as number of milliseconds since the Unix Epoch.
@vector-of-bool
Copy link
Contributor Author

Rebased onto the recent master branch has test results in-sync with that branch. Should be ready to merge?

Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge.

@vector-of-bool vector-of-bool merged commit c6b1ed0 into mongodb:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants