CDRIVER-4056 Send LB in handshake and reject non-LB connections #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
force-pushed
the
connection_pooling.loadbalancer
branch
from
2fffa97 to
8cc94b1
Compare
kevinAlbs
force-pushed
the
connection_pooling.loadbalancer
branch
from
8cc94b1 to
b790410
Compare
chardan
approved these changes
Jul 22, 2021
| */ | ||
| bool | ||
| mongoc_server_description_service_id ( | ||
| const mongoc_server_description_t *description, bson_oid_t *oid); |
There was a problem hiding this comment.
nit: It's probably overly-pedantic, as basically nobody writes this, but did you mean:
bool
mongoc_server_description_service_id (
const mongoc_server_description_t * const description, bson_oid_t *oid);
There was a problem hiding this comment.
I did not. I do not think a const pointer adds a guarantee from the caller's perspective.
If mongoc_server_description_service_id promises not to change what description points to, a caller could not observe it.
There was a problem hiding this comment.
+1. And I don't think it really buys anything, either.
benjirewis
approved these changes
Jul 23, 2021
src/libmongoc/doc/errors.rst
Outdated
| @@ -31,6 +31,8 @@ Many C Driver functions report errors by returning ``false`` or -1 and filling o | |||
| +-----------------------------------------+---------------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | |||
| | | ``MONGOC_ERROR_CLIENT_INVALID_ENCRYPTION_STATE`` | Failure related to Client-Side Field Level Encryption. | | |||
| +-----------------------------------------+---------------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | |||
| | | ``MONGOC_ERROR_CLIENT_INVALID_LOAD_BALANCER`` | You attempted to connect to a MongoDB server behind a load balancer, but the server does not advertise load balanced support. | | |||
There was a problem hiding this comment.
British spelling for advertise but I assume this error message was copied from somewhere.
There was a problem hiding this comment.
TIL I've been using the British spelling. Updated.
kevinAlbs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.