Skip to content

CDRIVER-4113: Thread-safe pool for server session objects #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Sep 13, 2021
Merged

CDRIVER-4113: Thread-safe pool for server session objects #847

merged 23 commits into from
Sep 13, 2021

Conversation

vector-of-bool
Copy link
Contributor

No description provided.

@kevinAlbs kevinAlbs requested a review from aggrand August 12, 2021 14:59
kevinAlbs
kevinAlbs reviewed Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great start! I like the generally useful mongoc_ts_pool type.

aggrand
aggrand reviewed Aug 23, 2021
View reviewed changes
Copy link

@aggrand aggrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a few questions, but this is looking great! I'm excited for these changes!

kevinAlbs
kevinAlbs reviewed Aug 25, 2021
View reviewed changes
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you for the thorough comments in mongoc-ts-pool-private.h.

@vector-of-bool vector-of-bool mentioned this pull request Aug 27, 2021
Merged
eramongodb
eramongodb requested changes Sep 1, 2021
View reviewed changes
@vector-of-bool
Copy link
Contributor Author

Looks like there is a warning-as-error for -Waggregate-return. Some digging suggests this is an archaic warning. It's listed in maintainer-flags.txt, but I don't know why it was added.

@vector-of-bool
Copy link
Contributor Author

I cannot find any compelling reason to keep -Waggregate-return, so I simply removed it. Are there any objections?

kevinAlbs
kevinAlbs reviewed Sep 8, 2021
View reviewed changes
eramongodb
eramongodb reviewed Sep 9, 2021
View reviewed changes
@vector-of-bool
Copy link
Contributor Author

I believe that everything should be happy now, sans flaky test failures.

eramongodb
eramongodb reviewed Sep 10, 2021
View reviewed changes
kevinAlbs
kevinAlbs approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, LGTM!

eramongodb
eramongodb reviewed Sep 13, 2021
View reviewed changes
Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor feedback and questions, but overall changes LGTM!

@vector-of-bool vector-of-bool merged commit 9a0ab6c into mongodb:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinAlbs kevinAlbs kevinAlbs approved these changes

@eramongodb eramongodb eramongodb approved these changes

@aggrand aggrand Awaiting requested review from aggrand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vector-of-bool @kevinAlbs @aggrand @eramongodb