Skip to content

CDRIVER-4155 address deadStore warnings #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2021
Merged

CDRIVER-4155 address deadStore warnings #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58f6fba
CDRIVER-4155 address deadStore warnings
kevinAlbs Sep 10, 2021
efb0888
Ezra comments
kevinAlbs Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/libbson/src/bson/bson-decimal128.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,8 +709,6 @@ bson_decimal128_from_string_w_len (const char *string, /* IN */
}

/* Encode significand */
significand_high = 0, /* The high 17 digits of the significand */
significand_low = 0; /* The low 17 digits of the significand */

if (significant_digits == 0) { /* read a zero */
significand_high = 0;
Expand Down
3 changes: 1 addition & 2 deletions src/libmongoc/tests/mock_server/mock-rs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,6 @@ mock_rs_run (mock_rs_t *rs)
{
int i;
mock_server_t *server;
char *hosts_str;
char *hello;

if (rs->has_primary) {
Expand Down Expand Up @@ -368,7 +367,7 @@ mock_rs_run (mock_rs_t *rs)


/* now we know all servers' ports and we have them in one array */
rs->hosts_str = hosts_str = hosts (&rs->servers);
rs->hosts_str = hosts (&rs->servers);
rs->uri = make_uri (&rs->servers);

BSON_ASSERT (rs->max_wire_version > 0);
Expand Down
3 changes: 1 addition & 2 deletions src/libmongoc/tests/test-mongoc-rpc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,6 @@ test_mongoc_rpc_reply_scatter2 (void)
bson_reader_t *reader;
uint8_t *data;
mongoc_rpc_t rpc;
const bson_t *b;
bool r;
bool eof = false;
bson_t empty;
Expand All @@ -508,7 +507,7 @@ test_mongoc_rpc_reply_scatter2 (void)
ASSERT (rpc.reply.documents_len == 16200);
reader =
bson_reader_new_from_data (rpc.reply.documents, rpc.reply.documents_len);
while ((b = bson_reader_read (reader, &eof))) {
while (bson_reader_read (reader, &eof)) {
count++;
}
ASSERT (eof == true);
Expand Down