CDRIVER-4184 don't emit closed on invalid topology #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chardan
suggested changes
Oct 31, 2021
| @@ -617,7 +617,12 @@ mongoc_topology_destroy (mongoc_topology_t *topology) | |||
| bson_mutex_destroy (&topology->apm_mutex); | |||
| mongoc_cond_destroy (&topology->srv_polling_cond); | |||
| } | |||
| _mongoc_topology_description_monitor_closed (&topology->description); | |||
|
|
|||
| if (topology->valid) { | |||
There was a problem hiding this comment.
+1 I'm assuming that this is okay via spec. (Also, re-read the bug report makes sense! Thank you.)
There was a problem hiding this comment.
The SDAM monitoring spec defines the TopologyOpening event as:
When a topology description is initialized - this MUST be the first SDAM event fired
I interpret that to mean it is OK to omit a TopologyOpening event if the topology fails to initialize. That is the current behavior. And I think it follows that a TopologyClosed event must not be omitted either.
kmahar
approved these changes
Oct 31, 2021
There was a problem hiding this comment.
thanks @kevinAlbs! I ran a patch with the Swift driver and your branch here vendored in and the DNS seedlist test that was crashing due to this issue now passes.
chardan
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.