Skip to content

CDRIVER-4222 add _mongoc_ssl_opts_from_bson #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 8, 2021
Merged

CDRIVER-4222 add _mongoc_ssl_opts_from_bson #886

merged 5 commits into from
Nov 8, 2021

Conversation

kevinAlbs
Copy link
Collaborator

@kevinAlbs kevinAlbs commented Nov 8, 2021 •
edited
Loading

Resolves CDRIVER-4222.

@kevinAlbs kevinAlbs marked this pull request as ready for review November 8, 2021 00:35
chardan
chardan approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@chardan chardan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me! I don't see any must-do changes, but I have made some suggestions for you to consider; you might want to look at the one error message that's different and make it consistent (something the suggestion does help with).

vector-of-bool
vector-of-bool approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevinAlbs kevinAlbs merged commit a618423 into mongodb:master Nov 8, 2021
@kevinAlbs kevinAlbs deleted the tls_from_bson.4222 branch November 8, 2021 21:16
@kevinAlbs kevinAlbs restored the tls_from_bson.4222 branch February 3, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chardan chardan chardan approved these changes

@vector-of-bool vector-of-bool vector-of-bool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinAlbs @chardan @vector-of-bool