CDRIVER-4215 use legacy atomic built-ins on gcc (>= 4.1, < 4.9) #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vector-of-bool
approved these changes
Nov 8, 2021
kevinAlbs
reviewed
Nov 9, 2021
rcsanchez97
force-pushed
the
cdriver-4215
branch
from
b8ce3a9 to
7df151b
Compare
rcsanchez97
changed the title
|
Full patch build with these changes: https://spruce.mongodb.com/version/618d4fc82fbabe51bb1beb05/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC |
|
The last changes that I pushed constitute two things:
The full patch build that I submitted shows that on RHEL 6 and 7 the compile tasks and now some of the tests pass. There are still numerous test tasks that are failing, but those failures are unrelated. |
kevinAlbs
approved these changes
Nov 11, 2021
| Assert (got, ==, 9); \ | ||
| Assert (value, ==, 9); \ | ||
| /* Compare-exchange-weak succeed: */ \ | ||
| /* 'weak' may fail spuriously, so it must *eventually* succeed */ \ |
There was a problem hiding this comment.
Can't argue with that haha.
vector-of-bool
approved these changes
Nov 11, 2021
|
@vector-of-bool Does that comment work for you? |
|
Yes, that comment is helpful |
rcsanchez97
force-pushed
the
cdriver-4215
branch
from
8533dd9 to
066e059
Compare
This was referenced Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is not yet complete. However, given the scope of the change just in getting the compile to succeed on RHEL 6, it seemed prudent to push my first set of changes as a WIP PR.
Initial patch build: https://spruce.mongodb.com/version/61874ce932f4177a1ad61efb/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
@vector-of-bool In the patch build, you will want to focus on the compile task in the
rhel62variant. The test tasks are still failing, but for unrelated reasons. At this point I am specifically interested to know if you find any errors or deficiencies in my initial changes.After I get the compile working on RHEL 7 I will take a look at all the warnings that are still being produced.