CDRIVER-4207 handshake on new stream in scanner #915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Always send the full connection handshake as the first command on a stream in single-threaded monitoring. The bug described in CDRIVER-4207 results in a monitoring command as the first command.
Rejected ideas
I rejected the idea of setting
last_failed
inmongoc_topology_scanner_node_disconnect
.last_failed
is used to applycooldownMS
inmongoc_topology_scanner_node_in_cooldown
. The Server Monitoring spec does not say thatcooldownMS
should apply when a network error occurs on an application operation.