Skip to content

CDRIVER-4247 Replace cmakedefine01 with autotools-compatible equivalent #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2021
Merged

CDRIVER-4247 Replace cmakedefine01 with autotools-compatible equivalent #917

merged 1 commit into from
Dec 17, 2021

Conversation

eramongodb
Copy link
Contributor

Per CDRIVER-4247 description, the #cmakedefine01 preprocessor directive breaks PHPC compatibility, which compiles the C driver using autotools rather than CMake. This PR substitutes the CMake-specific directive with an equivalent and autotools-compatible pattern already being used by similar preprocessor macros.

@eramongodb eramongodb self-assigned this Dec 17, 2021
vector-of-bool
vector-of-bool approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. LGTM.

jmikola
jmikola approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response on this!

kevinAlbs
kevinAlbs approved these changes Dec 17, 2021
View reviewed changes
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the quick fix.

@eramongodb eramongodb merged commit 296ff38 into mongodb:master Dec 17, 2021
@eramongodb eramongodb deleted the cdriver-4247 branch December 17, 2021 21:13
@eramongodb eramongodb mentioned this pull request Dec 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

@kevinAlbs kevinAlbs kevinAlbs approved these changes

@vector-of-bool vector-of-bool vector-of-bool approved these changes

Assignees

@eramongodb eramongodb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eramongodb @jmikola @kevinAlbs @vector-of-bool