CDRIVER-4264 Address build failures on VS 2013 variants on Evergreen #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vector-of-bool
approved these changes
Jan 21, 2022
|
It appears not. A patch build verifying these changes (with minor discrepancies in the diff compared to this PR) are available here for reference. |
kevinAlbs
approved these changes
Jan 22, 2022
src/libbson/src/bson/bson-atomic.c
Outdated
| @@ -48,7 +48,7 @@ bson_memory_barrier (void) | |||
| } | |||
|
|
|||
| /** | |||
| * Some platforms do not support compiler intrinsics for atomic operations. | |||
| * Some platforms do not support compiler ics for atomic operations. | |||
There was a problem hiding this comment.
Yes. Thank you for the catch.
src/libbson/src/bson/bson-atomic.h
Outdated
| @@ -73,6 +73,12 @@ enum bson_memory_order { | |||
| #define BSON_EMULATE_INT | |||
| #endif | |||
|
|
|||
| /* CDRIVER-4264 Contrary to documentation, VS 2013 targeting x86 does not | |||
| * correctly/consistently provide _IntrinsicPointerExchange. */ | |||
There was a problem hiding this comment.
Suggested change
| * correctly/consistently provide _IntrinsicPointerExchange. */ | |
| * correctly/consistently provide _InterlockedExchangePointer. */ |
There was a problem hiding this comment.
Thank you. I keep mistakening "Interlocked" as "Intrinsic". Will fix. 😑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per CDRIVER-4264, there are three compilation errors preventing successful compilation on VS 2013 variants. This PR addresses each of these warnings:
'_Exit' undefined; assuming extern returning intVS 2013 only provides partial support for the C99 standard. This support apparently does not extend to providing the
_Exitfunction, which is a C99 feature. Given that its use in the test suite (to report the type of signal triggering failure) is not strictly necessary, I have opted for its removal.'snprintf' undefined; assuming extern returning intsnprintfis also a C99 feature. Some files in libmongoc were directly invokingsnprintfdespite libbson providingbson_snprintfto address standard / platform compatibility issues. These instances were substituted withbson_snprintf.'_InterlockedExchangePointer': identifier not foundThis issue only manifested when building with VS 2013 targeting x86 (i686). I do not yet fully understand the reason behind this issue. According to a Boost patch (note, "MSVC-12" == "VS 2013") in response to a report of similar build failures, the issue is apparently due to a conflict between the
<intrin.h>and<winnt.h>libraries when targeting x86 with VS 2013. This is in spite of Microsoft documentation indicating support for the intrinsic when targeting x86. Consequently, I have opted to emulating the intrinsic given VS 2013 and x86.