Reducing Warnings - Miscellaneous Warnings #958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first in a series of PRs intended to reduce the set of warnings currently being observed when building the C driver.
This PR addresses the following warnings:
The LLDLinker module as currently written does not support MSVC, but was being unconditionally included. Its inclusion has been conditioned on not being compiled with MSVC.
-fPICon WindowsMSVC does not recognize the
-fPICflag, but it was being unconditionally passed as an compilation argument. Instances of the flag have been replaced by use of theENABLE_PICCMake configuration option.size_tandssize_tThe format specifiers in assertion macros comparing
size_tandssize_tvalues were using incorrectly/inconsistent specifiers.size_twas being printed using the signed specifier, andssize_twas being printed in hexadecimal representation. They have been fixed to use the correct specifier for signedness (unsigned and signed) and consistent representation (both in decimal).A stray C++ style comment in kms_request_str.c has been edited to conform to C90 requirements.