CDRIVER-4317 Add support for clientEncryption entity in unified test runner #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
requested changes
Apr 27, 2022
There was a problem hiding this comment.
Looks great. Thank you for adding the actual value to the match message.
Please update with the new runOnRequirement. That may resolve test failures.
|
Resolved merge conflicts and verified expected behavior in a full patch build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of CDRIVER-4317. It is being reviewed separately to unblock FLE 2 work.
This PR implements support for the new
clientEncryptionentity in unified tests. The JSON schema version is bumped from 1.5 to 1.8 to support running new unified test format valid-pass test files. This does not indicate that the unified test runner supports JSON schema version 1.8 in its entirety (not all spec tests have been updated).This PR includes a drive-by improvement to unified test runner error messages to support outputting the actual value of a BSON document when it differs from the expected value.
PR Updates
runOnRequirement.csfleto avoid test runner errors when built without CSFLE.