Skip to content

Fixes for csfle downloading on some Linux platforms #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Apr 28, 2022
Merged

Fixes for csfle downloading on some Linux platforms #977

merged 54 commits into from
Apr 28, 2022

Conversation

vector-of-bool
Copy link
Contributor

This fixes some CI failures that appeared following the merge of #968 : In particular, some older Linux platforms are missing Python features that mongodl used, and some platforms do not have csfle available at all (For these it is conditionally disabled). These changes have been tested on all erring platforms.

@vector-of-bool
Add mlib to the source tree
ae134d1
@vector-of-bool
No -Winline
70cbd72
@vector-of-bool
Tweak mlib usage in CMake
bd6501d
@vector-of-bool
Incorporate changes for csfle in libmongocrypt
e6363ba
@vector-of-bool
Enable C99 as the default language mode for the project
cddf5c7
@vector-of-bool
Tweak macro name
33827b6
@vector-of-bool
Test case to check linker symbol merging
44ff2e8
@vector-of-bool
Missing dist listing
4099263
@vector-of-bool
Merge branch 'master' into adopt-csfle
cbdc11a
@vector-of-bool
test-libmongoc might not be created
21c5581
@vector-of-bool
MinGW lacks WC_ERR_INVALID_CHARS
cbfdfca
@vector-of-bool
Document new extraOptions for auto-encryption
834308f
@vector-of-bool
Remove mlib for now
a334c4e
@vector-of-bool
Add mongodl, download a csfle library for testing. Use csfle in test …
17687a7 
…processes if possible
@vector-of-bool
Fix: forked child processes must not used exit() nor allocating funct…
2566d33 
…ions.

This is discovered because the mongocryptd spawner will cause the
atexit() code to run from the csfle library loaded in the
process.
@vector-of-bool
C99 is not required
8328de4
@vector-of-bool
mlib is not part of the dist any more
c966020
@vector-of-bool
Fix platform detection in mongodl
46fde37
@vector-of-bool
Tweak filter output for --list
3a20ed6
@vector-of-bool
Various spelling
6c6b01e
@vector-of-bool
Only download csfle if we are building tests
3b7bb90
@vector-of-bool
mongodl: Default edition is 'enterprise'
58fc76a
@vector-of-bool
Do not append csfle search paths if we are explicit or bypassing auto…
864e513 
…-encryption

Refer: [DRIVERS-2287]
@vector-of-bool
Make a USE_CSFLE option to control whether we use csfle for testing. Fix
a41f7c9 
CMake formatting
@vector-of-bool
Address PR comments. Tweak doc wording.
53ed65e
@vector-of-bool
Fix mongodl for rhel versions and ASCII stdout
c6a78b1
@vector-of-bool
Prefer find_program() for finding Python3
addb083
@vector-of-bool
Fix Ubuntu detection. Small formatting
aac7994
@vector-of-bool
Missing dist for mongodl
40a2612
@vector-of-bool
Using an $ORIGIN based path for the csfle library
ccc2547
@vector-of-bool
Disable csfle for tests that rely on mongocryptd behaviors
c82bdb1
@vector-of-bool
Speeling
57e53b7
@vector-of-bool
Indentation fix
966d303
@vector-of-bool
Clearer assertion error message
ec9ec9a
@vector-of-bool
Use POSIX _exit instead of wrapping it
606b1a5
@vector-of-bool
Formatting
37cb34d
@vector-of-bool
csfle placement is difficult
aa5180b
@vector-of-bool
Just put it in the top directory for now
3c8ccfa
@vector-of-bool
Just use 'find'
45a9bf2
@vector-of-bool
Better find, better output path
c497d22
@vector-of-bool
Remove BSON_MEMCHECK. We're getting ODR trouble.
eda94f6
@vector-of-bool
Tell me what you did.
7654848
@vector-of-bool
No csflePath on Windows yet
5e29834
@vector-of-bool
Remove __csfleDisabled option
281df33
@vector-of-bool
Skip failing CSE tests for now
c7d54b4
@vector-of-bool
Fix mongodl for older Python versions
a4363a7
@vector-of-bool
Older Python3 has limitted pathlib functions
4635971
@vector-of-bool
Archlinux is a special case. Just use RHEL8 binaries
760ad4c
@vector-of-bool
Even older Linuxes
f959f04
@vector-of-bool
Disable csfle download if there is no version download available for …
80dce13 
…the system.
eramongodb
eramongodb reviewed Apr 28, 2022
View reviewed changes
@vector-of-bool vector-of-bool merged commit ca5af4d into mongodb:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinAlbs kevinAlbs kevinAlbs approved these changes

@eramongodb eramongodb eramongodb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vector-of-bool @kevinAlbs @eramongodb