CDRIVER-4358 sync allowDiskUse CRUD spec tests #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full Evergreen patch build: https://spruce.mongodb.com/version/626c8db630661566a405605d/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
I synced all the spec tests associated with the
allowDiskUseoption and ran a patch build. There were no failures present in the patch build that weren't in the base commit (except for one spurious TSAN failure). I also checked to ensure that we aren't skipping any of the tests associated withallowDiskUse. Apart from the spec tests themselves, there are only two mentions ofallowDiskUsein the C driver code:test-mongoc-collection.c, where it is set as an option as part of a specific testmongoc_collection_find_with_opts.rstwhere its existence and type is documentedNeither of those occurrences appear to require a change as part of this ticket.