Skip to content

Update bundled zlib to 1.2.12 #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2022

Conversation

vector-of-bool
Copy link
Contributor

This addresses [CDRIVER-4377]

I've pruned all subdirectories of the zlib bundle, since none of them seem to be used by mongo-c and theywould just bloat the repo.

Copy link
Contributor

@rcsanchez97 rcsanchez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a comment about the make-release-archive task.

src/zlib-1.2.12/trees.h
src/zlib-1.2.12/zconf.h.in
src/zlib-1.2.12/zlib.h
src/zlib-1.2.12/zutil.h
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task failure on make-release-archive looks relevant:

[2022/05/02 21:09:58.960] Repository has the following files NOT in tarball
[2022/05/02 21:09:58.960] zlib-1.2.12/zconf.h

This may need an additional entry for src/zlib-1.2.12/zconf.h.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's actually supposed to be generated and not committed to the repo

@vector-of-bool vector-of-bool merged commit 1a62f76 into mongodb:master May 3, 2022
kevinAlbs pushed a commit that referenced this pull request May 15, 2022
* Update bundled zlib to 1.2.12 [Close CDRIVER-4377]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants