Skip to content

CDRIVER-4369 Add FLE 2 API to AutoEncryptionOpts #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 14, 2022

Conversation

kevinAlbs
Copy link
Collaborator

@kevinAlbs kevinAlbs commented May 10, 2022

Summary

  • Do not return error on "ns not found" error in drop with encryptedFields.
  • Pass encrypted_fields_map to libmongocrypt.
  • Add add mongoc_auto_encryption_opts_set_bypass_query_analysis.
  • Require libmongocrypt version 1.5.0.
  • Update csfle test dependency to 6.0.0-rc4.
  • Do not spawn mongocryptd if bypass_query_analysis is true.

Background & Motivation

The "ns not found" error is returned by the "drop" command if the collection does not exist. All drivers excluding Node and C ignore this error in their drop helpers. See Do drivers ignore "ns not found" in collection drop?. Ignoring the "ns not found" error in the drop operation with encryptedFields is consistent with Node's implementation..

Using csfle version 5.3.1 resulted in the following error:

Expected success, got error "csfle "analyze_query" failed: jsonSchema is a required command field [Error 2, code 51073]"

That error suggests 5.3.1 does not have all FLE 2 features. jsonSchema is only required for FLE 1. Updating to 6.0.0-rc4 resolved this error.

@kevinAlbs kevinAlbs marked this pull request as ready for review May 10, 2022 15:04
@kevinAlbs kevinAlbs requested a review from vector-of-bool May 10, 2022 15:04
kevinAlbs added 2 commits May 11, 2022 13:25
…ptd_not_spawned

This makes _check_mongocryptd_not_spawned more consistently assert if mongocryptd was spawned.
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinAlbs kevinAlbs merged commit 1841a0e into mongodb:master May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants