CSHARP-4378: add integration tests for Azure KMS #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryLukyanov
changed the title
BorisDog
reviewed
Oct 24, 2022
build.cake
Outdated
| items: GetFiles("./**/*.Tests.csproj"), | ||
| action: (BuildConfig buildConfig, Path testProject) => | ||
| { | ||
| var settings = new DotNetTestSettings |
There was a problem hiding this comment.
Maybe this is a good opportunity to refactor all such repeating code to
Test(string testFilter) or GetTestSettings(string testFilter)
There was a problem hiding this comment.
Good point, I also thought about something like this. I will try to do it
...Driver.Tests/Specifications/client-side-encryption/prose-tests/ClientEncryptionProseTests.cs
Show resolved
Hide resolved
...Driver.Tests/Specifications/client-side-encryption/prose-tests/ClientEncryptionProseTests.cs
Show resolved
Hide resolved
BorisDog
approved these changes
Oct 27, 2022
| testProject.FullPath, | ||
| settings | ||
| ); | ||
| RunTests(buildConfig, testProject); |
| @@ -975,3 +772,25 @@ string[] CreateLoggers() | |||
| var consoleLogger = "console;verbosity=detailed"; | |||
| return new []{ junitLogger, consoleLogger }; | |||
| } | |||
|
|
|||
| void RunTests(BuildConfig buildConfig, Path path, string filter = null) | |||
There was a problem hiding this comment.
Maybe consider overload with component instead of filter, as in practice we use only component.
There was a problem hiding this comment.
discussed offline, we can reconsider it later
dnickless
pushed a commit
to dnickless/mongo-csharp-driver
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.