CSHARP-4361: Add log messages to CMAP spec #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesKovacs
requested review from
DmitryLukyanov
and removed request for
JamesKovacs
DmitryLukyanov
approved these changes
Nov 17, 2022
| @@ -68,7 +68,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <EmbeddedResource LinkBase="Specifications\connection-monitoring-and-pooling" Include="..\..\specifications\connection-monitoring-and-pooling\**\*.json" /> | |||
| <EmbeddedResource LinkBase="Specifications\connection-monitoring-and-pooling\tests\cmap-format" Include="..\..\specifications\connection-monitoring-and-pooling\tests\cmap-format\*.json" /> | |||
There was a problem hiding this comment.
nit: why didn't you use **?
There was a problem hiding this comment.
We just need to include the cmap-format folder. Logging folder is included in Driver.Tests.
| public class CmapUnifiedTestRunner : LoggableTestClass | ||
| { | ||
| private static readonly HashSet<string> __ignoredLogsMessages = new HashSet<string>(new[] | ||
| { |
There was a problem hiding this comment.
I think expected formatting here:
private static readonly HashSet<string> __ignoredLogsMessages = new HashSet<string>(
new[]
{
..
}
dnickless
pushed a commit
to dnickless/mongo-csharp-driver
that referenced
this pull request
Aug 24, 2023
* CSHARP-4361: Add log messages to CMAP spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.