CSHARP-4386: Test mongocryptd is not spawned when shared library is loaded. #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryLukyanov
changed the title
JamesKovacs
requested review from
BorisDog
and removed request for
JamesKovacs
BorisDog
reviewed
Nov 25, 2022
| var clientEncryptedSchema = new BsonDocument("db.coll", JsonFileReader.Instance.Documents["external.external-schema.json"]); | ||
| var cryptSharedPath = CoreTestConfiguration.GetCryptSharedLibPath(); | ||
| Ensure.That(File.Exists(cryptSharedPath), $"Shared library path {cryptSharedPath} is not valid."); | ||
| var effectiveExtraOptions = new Dictionary<string, object>(extraOptions) |
There was a problem hiding this comment.
Where effectiveExtraOptions is used?
There was a problem hiding this comment.
good point, fixed. The test actually behaves almost the same even without this configuration because a shared library is configured by default, but it's definitely better to have it configured explicitly.
BorisDog
reviewed
Nov 25, 2022
| }; | ||
| return ConfigureClientEncrypted(kmsProviderFilter: kmsProvider, schemaMap: clientEncryptedSchema, extraOptions: extraOptions); | ||
| } | ||
| default: throw new Exception($"Invalid bypass mongocryptd {bypassSpawning} option."); |
There was a problem hiding this comment.
nit: ArgumentOutOfRangeException?
There was a problem hiding this comment.
In this file, we use Exception in other places. I don't have strong preference in general what exception better to use, but mostly in tests we use just Exception
dnickless
pushed a commit
to dnickless/mongo-csharp-driver
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.