CSHARP-4413: Equality operator of MongoClientSettings is bugged #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1109,7 +1109,7 @@ public override bool Equals(object obj) | |||
| _useTls == rhs._useTls && | |||
| _waitQueueSize == rhs._waitQueueSize && | |||
| _waitQueueTimeout == rhs._waitQueueTimeout && | |||
| _writeConcern == rhs._writeConcern && | |||
| object.Equals(_writeConcern, rhs._writeConcern) && | |||
There was a problem hiding this comment.
maybe better implementing operator ==?
There was a problem hiding this comment.
I agree, I thought this might be BC, but looks like it's minor. Thoughts @DmitryLukyanov ?
There was a problem hiding this comment.
yeah, it's a BC, but I also think it's minor and I don't see how it can affect users, so I think it's better to do it
There was a problem hiding this comment.
I think as a general rule Equals should be implemented in terms of Equals.
Sometimes we rely on == being equivalent to Equals but to me it's clearer if Equals is implemented using Equals.
There was a problem hiding this comment.
@DmitryLukyanov we address this in CSHARP-4432
dnickless
pushed a commit
to dnickless/mongo-csharp-driver
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.