CXX-3043 Address additional Ro3/Ro5 violations (#1145)

Author: eramongodb

src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/builder/basic/array.hpp

@@ -39,17 +39,22 @@ class array : public sub_array {
     ///
     /// Default constructor
     ///
-    BSONCXX_INLINE array() : sub_array(&_core), _core(true) {}
+    array() : sub_array(&_core), _core(true) {}
+
+    ///
+    /// Destructor
+    ///
+    ~array() = default;
 
     ///
     /// Move constructor
     ///
-    BSONCXX_INLINE array(array&& arr) noexcept : sub_array(&_core), _core(std::move(arr._core)) {}
+    array(array&& arr) noexcept : sub_array(&_core), _core(std::move(arr._core)) {}
 
     ///
     /// Move assignment operator
     ///
-    BSONCXX_INLINE array& operator=(array&& arr) noexcept {
+    array& operator=(array&& arr) noexcept {
         _core = std::move(arr._core);
         return *this;
     }

src/mongocxx/lib/mongocxx/v_noabi/mongocxx/private/index_view.hh

@@ -261,9 +261,24 @@ class index_view::impl {
     class scoped_server_description {
        public:
         explicit scoped_server_description(mongoc_server_description_t* sd) : sd(sd) {}
+
         ~scoped_server_description() {
             mongoc_server_description_destroy(sd);
         }
+
+        scoped_server_description(scoped_server_description&& other) : sd(other.sd) {
+            other.sd = nullptr;
+        }
+
+        scoped_server_description& operator=(scoped_server_description&& other) {
+            sd = other.sd;
+            other.sd = nullptr;
+            return *this;
+        }
+
+        scoped_server_description(const scoped_server_description&) = delete;
+        scoped_server_description& operator=(const scoped_server_description&) = delete;
+
         mongoc_server_description_t* sd;
     };
 };