Skip to content

Add CHANGELOG.md #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Add CHANGELOG.md #1010

merged 4 commits into from
Aug 21, 2023

Conversation

kevinAlbs
Copy link
Collaborator

@kevinAlbs kevinAlbs commented Aug 16, 2023

Summary

This PR proposes adding a changelog to track notable changes in releases.

Changes were tested by locally tagging a commit with r3.9.0 and temporarily tweaking the script to produce a draft. Here is a sample draft of the produced release notes:
https://github.com/mongodb/mongo-cxx-driver/releases/tag/untagged-fd8ab6ba4086415ac8fa

Background & Motivation

Having a CHANGELOG may reduce work during releases:

  • The release notes for 3.8.0 included written notes not generated by make_release.py. Notes can be written incrementally with the changes.
  • Tickets requiring release notes can be resolved before a release. Example: CXX-2662.

Listing individual Jira tickets is intentionally removed. IMO a copied list of tickets does not provide much value over linking to Jira. Providing a high level overview of changes may be more helpful. Readers can follow the Jira link or see commits for details.

Add step to consider updating CHANGELOG.md
Revise ticket auditing to remove suggestion that ticket titles are used in release notes.
@kevinAlbs kevinAlbs marked this pull request as ready for review August 16, 2023 15:05
Copy link
Contributor

@rcsanchez97 rcsanchez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reminds of a nicer version of csv2cl and svn2cl. I like the utility of this for users and I also like that it doesn't just reproduce the git commit history (since lots of changes aren't interesting to users).

Do you need an approval so that you can merge this, or are you still thinking about other related changes in this PR or something like that?

@kevinAlbs
Copy link
Collaborator Author

Do you need an approval so that you can merge this, or are you still thinking about other related changes in this PR or something like that?

I am not planning on making more changes. At least one approval is needed to merge. I plan to ask for opinions in the team channel again before merging.

@rcsanchez97
Copy link
Contributor

Do you need an approval so that you can merge this, or are you still thinking about other related changes in this PR or something like that?

I am not planning on making more changes. At least one approval is needed to merge. I plan to ask for opinions in the team channel again before merging.

OK. I'll add a LGTM so that you can merge when you're ready.

@kevinAlbs kevinAlbs merged commit 5356841 into mongodb:master Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants