Skip to content

CXX-2751 Fix reference to VERSION_CURRENT file in distribution list #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

eramongodb
Copy link
Contributor

@eramongodb eramongodb commented Sep 12, 2023

Addresses CXX-2751. Verified by this patch.

Ensures build/VERSION_CURRENT is not unconditionally included in the distribution list when it may not actually exist (BUILD_VERSION set manually or VERSION_CURRENT found in the binary directory). This addresses missing rule issues with dist target dependency requirements for some CMake generators (i.e. Ninja).

@eramongodb eramongodb self-assigned this Sep 12, 2023
Copy link
Contributor

@rcsanchez97 rcsanchez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eramongodb eramongodb merged commit b133ac5 into mongodb:master Sep 13, 2023
@eramongodb eramongodb deleted the cxx-2751 branch September 13, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants