Skip to content

CXX-2754 Add MONGOCXX_COMPILER_* macros to push-pop headers #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

eramongodb
Copy link
Contributor

@eramongodb eramongodb commented Sep 13, 2023

Resolves CXX-2754. Followup to #915. CXX-2284 added MONGOCXX_COMPILER_ID and MONGOCXX_COMPILER_VERSION to config.hh.in but did not add corresponding push-pop guards to prelude.hh and postlude.hh.

@eramongodb eramongodb self-assigned this Sep 13, 2023
@eramongodb eramongodb changed the title CXX-2284 Add MONGOCXX_COMPILER_* macros to push-pop headers CXX-2754 Add MONGOCXX_COMPILER_* macros to push-pop headers Sep 13, 2023
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@eramongodb eramongodb merged commit 60a3e7c into mongodb:master Sep 13, 2023
@eramongodb eramongodb deleted the cxx-2284 branch September 13, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants