[CXX-2625] Bring our own make_unique #1028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vector-of-bool
force-pushed
the
own-make_unique
branch
from
278ab88 to
38b4684
Compare
vector-of-bool
force-pushed
the
own-make_unique
branch
from
38b4684 to
aa8b45a
Compare
vector-of-bool
changed the title
kevinAlbs
approved these changes
Oct 17, 2023
|
|
||
| TEST_CASE("Create a unique_ptr") { | ||
| auto ptr = bsoncxx::stdx::make_unique<int>(12); | ||
| CHECKED_IF(ptr) { |
There was a problem hiding this comment.
Suggested change
| CHECKED_IF(ptr) { | |
| CHECK(ptr); | |
| CHECKED_IF(ptr) { |
Suggest checking ptr since CHECKED_IF only enters block if the expression evaluates to true.
Suggestion applies to other CHECKED_IF statements.
There was a problem hiding this comment.
I was going to say that this is desired behavior, but I double-checked the docs and
CHECKED_Xmacros were changed to not count as failure in Catch2 3.0.1.
😐
As someone that has used these macros heavily across dozens projects for several years and seems to have missed this release note, this is an extremely breaking change from Catch2, and there doesn't appear to be a viable alternative?? It seems that I have a lot of tests to go and fix now. I need to go lay down.
| * the length of the array to allocate. | ||
| * | ||
| * Requires: | ||
| * - T must be value-initializable |
There was a problem hiding this comment.
Suggested change
| * - T must be value-initializable | |
| * - T must be default-initializable |
adriandole
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer: CXX-2625. This changeset replaces our use of boost's
make_uniquewith our own implementation. This also includes some aside changes related to CMake target scripting.