CXX-2814 Remove BSONCXX_POLY_USE_STD_EXPERIMENTAL from polyfill options #1089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Jan 29, 2024
| @@ -63,14 +63,12 @@ function(bsoncxx_add_library TARGET OUTPUT_NAME LINK_TYPE) | |||
| set(polyfill "m") | |||
| elseif(BSONCXX_POLY_USE_BOOST) | |||
| set(polyfill "b") | |||
| elseif(BSONCXX_POLY_USE_STD_EXPERIMENTAL) | |||
There was a problem hiding this comment.
Remove # - 'x' for experimental standard library. above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
BSONCXX_POLY_USE_STD_EXPERIMENTALconfig option along with all related code and documentation given it's been explicitly documented as both not-recommend and unsupported since February 2018 in r3.2.0 (committed in April 2017), which should be more than enough time for users to have responded accordingly. Verified by this patch.