Skip to content

CXX-2803 Fix build type for mongocxx library's ABI tag #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

eramongodb
Copy link
Contributor

Followup to #1081 (CXX-2803).

Overlooked the removal of INTERFACE_BSONCXX_ABI_TAG_BUILD_TYPE in 73e40df impacting the derivation of the build type in MongocxxUtil.cmake, e.g.:

# There is no INTERFACE_BSONCXX_ABI_TAG_BUILD_TYPE property.
mongocxx-v_noabi-build_type-NOTFOUNDhs-x64-v142-mdd

This PR fixes the ABI tag such that the build type for mongocxx is consistent with bsoncxx.

@eramongodb eramongodb requested a review from kevinAlbs February 13, 2024 16:31
@eramongodb eramongodb self-assigned this Feb 13, 2024
@eramongodb eramongodb merged commit 08e7916 into mongodb:master Feb 13, 2024
@eramongodb eramongodb deleted the cxx-2803 branch February 13, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants