Avoid passing Linux-like flags on Windows distros #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
I'm not entirely sure why related tasks are succeeding on the main branch waterfall
I expect it is due to only including -Wno-deprecated-declarations on release branches:
# Ignore deprecation warnings when building on a release branch.
if [ "$(echo "${branch_name:?}" | cut -f2 -d'/')" != "${branch_name:?}" ]; then
cc_flags+=(-Wno-deprecated-declarations)
cxx_flags+=(-Wno-deprecated-declarations)
fi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior attempt: #1094 (patch failure due to base commit issues)
Addresses task failures on Windows distros in the r3.9 waterfall which are interfering with CXX-2818 validation. Verified by this patch.
Admittedly I'm not entirely sure why related tasks are succeeding on the main branch waterfall, but these are good changes to make regardless imo.