CXX-2971 Fix bsoncxx package name in pkg-config requires field #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eramongodb
referenced
this pull request
Feb 29, 2024
* Add ABI tag to library filenames on Windows * Update API/ABI documentation with Windows library filename description
7 tasks
kevinAlbs
approved these changes
Feb 29, 2024
eramongodb
added a commit
to eramongodb/mongo-cxx-driver
that referenced
this pull request
Feb 29, 2024
…db#1103) * Depend on CMake to handle quoting of command-line arguments correctly * CXX-2971 Fix bsoncxx package name in pkg-config requires list * Address "argument isn't numeric in numeric comparison" pkg-config warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-2971.
#1081 failed to account for
ENABLE_ABI_TAG_IN_PKGCONFIG_FILENAMES=OFFwhen generating pkg-config filenames (it works correctly whenENABLE_ABI_TAG_IN_PKGCONFIG_FILENAMES=ON). The "Requires" field for pkg-config files uses the package name, not the library filename. This PR ensures the bsoncxx library's pkg-config package name is used for theRequiresfield, not the library filename.The current EVG config does not appear to cover pkg-config on Windows. Testing pkg-config on Windows is currently being done manually and locally, which this PR proves to be insufficient. Filed CXX-2973 to track the addition of test coverage of pkg-config on Windows.
Some additional drive-by fixes/improvements:
"KEY=${VALUE_MAY_CONTAIN_SPACES}"rather thanKEY="${VALUE_MAY_CONTAIN_SPACES}".