CXX-2977 Support generator expressions in MSVC_RUNTIME_LIBRARY #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-2977.
#1081 failed to account for the possibility of generator expressions in
MSVC_RUNTIME_LIBRARY(either set directly or viaCMAKE_MSVC_RUNTIME_LIBRARY). This caused the series ofif()/elseif()whenMSVC_RUNTIME_LIBRARYis not-empty to fallthrough all string-comparison cases and produce output names with a trailing-and no runtime library property, e.g.mongocxx-v_noabi-dhs-x64-v143-.dll.This PR adds support for generator expressions by deferring the evaluation of the string comparison to the build generation step via the
$<STREQUAL:str1,str2>generator expression.