CXX-2793 Add scan-build tasks to EVG config #1126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Apr 24, 2024
vector-of-bool
approved these changes
Apr 26, 2024
.evergreen/compile-scan-build.sh
Outdated
Comment on lines
21
to
28
| scan_build_directories+=( | ||
| # Prefer toolchain scan-build if available. | ||
| "/opt/mongodbtoolchain/v4/bin" | ||
| "/opt/mongodbtoolchain/v3/bin" | ||
|
|
||
| # Use system scan-build otherwise. | ||
| "/usr/bin" | ||
| ) |
There was a problem hiding this comment.
Recommend consulting $PATH for other locations.
Suggested change
| scan_build_directories+=( | |
| # Prefer toolchain scan-build if available. | |
| "/opt/mongodbtoolchain/v4/bin" | |
| "/opt/mongodbtoolchain/v3/bin" | |
| # Use system scan-build otherwise. | |
| "/usr/bin" | |
| ) | |
| IFS=: read -ra sys_path <<< "$PATH" | |
| scan_build_directories+=( | |
| # Prefer toolchain scan-build if available. | |
| "/opt/mongodbtoolchain/v4/bin" | |
| "/opt/mongodbtoolchain/v3/bin" | |
| # Use system scan-build otherwise. | |
| "${sys_path[@]}" | |
| ) |
eramongodb
added a commit
that referenced
this pull request
Jun 24, 2024
* Add scan-build tasks to EVG config * Cleanup misc. EVG post command output * Add Coverity check to release instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-2793. Verified by this patch.
This PR adds five new scan-build tasks to the EVG config. The scan-build tasks mostly mirror those for the C Driver, but are parameterized on polyfill library selection and the C++ standard: three for each C++11 polyfill library configuration, one for C++14 with the bsoncxx implementation, and one for C++17 with the standard library. The mnmlstc/core and Boost tasks are expected to be removed as part of CXX-2797.
The release instructions are updated with a new entry instructing the maintainer to check Coverity for new, unexpected, or high severity issues. This step, as well as the regular preceeding "ensure tests are passing" check now that scan-build tasks are included, should be enough to satisfy the requirements for CXX-2793.
As a drive-by improvement, some EVG post commands were tweaked to avoid noisy error messages (empty tar archive, cd failure, etc.).