CXX-3008 replace invalid multiple Bash herestrings with output files #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vector-of-bool
approved these changes
Jun 24, 2024
.evergreen/check-augmented-sbom.sh
Outdated
Comment on lines
49
to
57
| [[ -f old.json ]] || { | ||
| echo "missing old.json" 1>&2 | ||
| exit 1 | ||
| } | ||
|
|
||
| [[ -f new.json ]] || { | ||
| echo "missing new.json" 1>&2 | ||
| exit 1 | ||
| } |
There was a problem hiding this comment.
Is it even possible for these files to not exist after the two shell redirects above?
There was a problem hiding this comment.
Fair. I suppose this is being a bit too defensive given diff will also error if the provided file doesn't exist. Will remove.
eramongodb
added a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1154. Sorry, I fell for the multiple herestring trap again (which is not supported by Bash). 🤦
This PR falls back to the old tried-and-true output file method instead of using procsubs and herestrings. Verified (properly) by this patch.