-
Notifications
You must be signed in to change notification settings - Fork 543
CXX-2828 QE Range Protocol V2 #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
requested changes
Sep 30, 2024
This reverts commit f75bdf6.
Co-authored-by: Kevin Albertson <[email protected]>
kevinAlbs
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with pending suggestions addressed.
Updating the branch may fix failing 4.2 tasks with the fix of daf2d38. You can git merge master
to avoid a rebase in the PR.
Sync to 06bceb0e86b50b0a183ffe994c2cc3a8bd653a1e. Not needed to fix tests, but included in CXX-3014
kevinAlbs
approved these changes
Oct 1, 2024
kevinAlbs
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses CXX-2828 and CXX-3014
Addresses several issues encountered attempting to run Range V2 tests:
Addresses issues encountered upgrading to C driver 1.28.0:
Add
-Wno-error=maybe-uninitialized
to RHEL 7.9. Intended to ignore this RHEL 7.9 (gcc 4.8.5) build task error:This appears to be a false positive. The
tmp
on line 1419 is a different variable from thetmp
in scope on 489.-Wno-error=maybe-uninitialized
was added to the RHEL 7.9 distro.Filed CXX-3112 to investigate a test failure with the legacy transactions test on sharded cluster tasks on 4.2. Appears unrelated to QE Range.