Skip to content

CXX-2811: Mark Server version 3.6 as EOL from driver's PoV (Min server version as 4.0, minWireVersion as 7.0) #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 25, 2024

Conversation

Julia-Garland
Copy link
Contributor

@Julia-Garland Julia-Garland commented Jul 24, 2024

Summary

Requirements resolved by CDRIVER-4815.

Removed non-spec tests that only ran on server version 3.6 or below and cleaned up if statements that ran on now always-true conditionals ex. max_wire_version >= 5.

@Julia-Garland Julia-Garland self-assigned this Jul 24, 2024
@Julia-Garland Julia-Garland requested a review from kevinAlbs July 24, 2024 16:54
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a revert to whitespace changes and additional dead code removal.

@Julia-Garland Julia-Garland marked this pull request as ready for review July 25, 2024 18:17
@Julia-Garland Julia-Garland merged commit d373213 into mongodb:master Jul 25, 2024
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants