CXX-3100 Check return when acquiring client from pool #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xception in case of an exception.
kevinAlbs
requested changes
Sep 9, 2024
|
Thank you for your suggestions. They really helped me understand mongocxx better. I've made all the changes you recommended, and the updated code has been committed. @kevinAlbs |
kevinAlbs
requested changes
Sep 10, 2024
src/mongocxx/include/mongocxx/v_noabi/mongocxx/exception/error_code.hpp
Outdated
Show resolved
Hide resolved
added 2 commits
September 10, 2024 21:32
|
Thanks for your patience. I have updated the code based on your suggestions. If there are any other issues, feel free to let me know. @kevinAlbs |
kevinAlbs
changed the title
kevinAlbs
changed the title
kevinAlbs
approved these changes
Sep 10, 2024
src/mongocxx/lib/mongocxx/v_noabi/mongocxx/exception/error_code.cpp
Outdated
Show resolved
Hide resolved
eramongodb
requested changes
Sep 10, 2024
src/mongocxx/lib/mongocxx/v_noabi/mongocxx/exception/error_code.cpp
Outdated
Show resolved
Hide resolved
…e.cpp Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
|
All changes have been applied to the branch. If there are any other issues, please feel free to point them out. @kevinAlbs @eramongodb |
eramongodb
approved these changes
Sep 11, 2024
src/mongocxx/include/mongocxx/v_noabi/mongocxx/exception/error_code.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Ezra Chung <[email protected]>
…_code.hpp Co-authored-by: Ezra Chung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This pull request fix one minor bug)
Symptom: When the uri parameter 'waitQueueTimeoutMS' was enabled and set to a smaller value (e.g. 100), the function 'mongoc_client_pool' may return a NULL client.
Solution: Add a check in the function 'pool::entry pool::acquire()', and throw an exception when correct client was not returned.