CXX-3082 Add examples for bsoncxx::v_noabi::builder::concatenate #1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
reviewed
Oct 4, 2024
src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/builder/concatenate.hpp
Outdated
Show resolved
Hide resolved
kevinAlbs
approved these changes
Oct 4, 2024
Comment on lines
91
to
92
| /// Use this with a document or array builder to merge an existing document's fields with that of | ||
| /// the document or array being built. |
There was a problem hiding this comment.
Suggested change
| /// Use this with a document or array builder to merge an existing document's fields with that of | |
| /// the document or array being built. | |
| /// Use this with a document builder to merge an existing document's fields with that of the | |
| /// document being built. |
Comment on lines
108
to
109
| /// Use this with a document or array builder to merge an existing array's fields with that of the | ||
| /// document or array being built. |
There was a problem hiding this comment.
Suggested change
| /// Use this with a document or array builder to merge an existing array's fields with that of the | |
| /// document or array being built. | |
| /// Use this with an array builder to merge an existing array's fields with that of the array being | |
| /// built. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1208. Prompted by CXX-2291.
Overlooked the addition of examples of using
concatenate(), which are currently only used in error handling examples for sub-document/sub-array exception recovery. Updates documentation ofconcatenate()overloads to avoid implying their use is specific to the stream builders.As a drive-by improvement, simplifies creation of arrays for examples by using
make_array(args...)instead of going throughfrom_json(R"({"v": [args...]})")["v"].get_array().value. ("When all you have is a hammer, ...")